absurdfarce commented on code in PR #1264: URL: https://github.com/apache/cassandra-python-driver/pull/1264#discussion_r2767610532
########## pyproject.toml: ########## @@ -0,0 +1,57 @@ +[build-system] +build-backend = "setuptools.build_meta" +requires = ["setuptools", "Cython>=3.0", "toml", "cassandra-driver"] Review Comment: I agree with this one; I was really confused when I had to do this to make things work. The underlying problem here is that setup.py gets __version__ from the "cassandra" package... so it needs this package to already be installed, which is indeed circular. Problem here is how to get around that: we want version to be handled canonically in pyproject.toml now but we also clearly need that to be accessible in Python code as well. Originally I fixed this by extracting version from the pyproject.toml code we're already parsing in setup.py but this isn't really satisfying... most notably it doesn't make the version available via cassandra.__version__. Next step was to switch over to the importlib.metadata package... that seemed to do the trick. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
