absurdfarce commented on code in PR #1264:
URL:
https://github.com/apache/cassandra-python-driver/pull/1264#discussion_r2767720955
##########
pyproject.toml:
##########
@@ -0,0 +1,57 @@
+[build-system]
+build-backend = "setuptools.build_meta"
+requires = ["setuptools", "Cython>=3.0", "toml", "cassandra-driver"]
+
+[project]
+name = "cassandra-driver"
+description = "Apache Cassandra Python Driver"
+dependencies = ['geomet>=1.1']
+readme = "README.rst"
+authors = [{name = "DataStax"}]
+license = "Apache-2.0"
+license-files = ["LICENSE"]
+keywords = ["cassandra","cql","orm","dse","graph"]
+classifiers = [
+ "Development Status :: 5 - Production/Stable",
+ "Intended Audience :: Developers",
+ "Natural Language :: English",
+ "Operating System :: OS Independent",
+ "License :: OSI Approved :: Apache Software License",
+ "Programming Language :: Python",
+ "Programming Language :: Python :: 3.9",
+ "Programming Language :: Python :: 3.10",
+ "Programming Language :: Python :: 3.11",
+ "Programming Language :: Python :: 3.12",
+ "Programming Language :: Python :: 3.13",
+ "Programming Language :: Python :: Implementation :: CPython",
+ "Programming Language :: Python :: Implementation :: PyPy",
+ "Topic :: Software Development :: Libraries :: Python Modules"
+]
+dynamic = ["version"]
+
+[project.optional-dependencies]
+graph = ["gremlinpython==3.4.6"]
+cle = ["cryptography>=42.0"]
+test = ["pytest", "PyYAML", "pytz"]
+
+[project.urls]
+homepage = "https://github.com/apache/cassandra-python-driver/";
+documentation = "https://docs.datastax.com/en/developer/python-driver/latest/";
+source = "https://github.com/apache/cassandra-python-driver/";
+issues =
"https://issues.apache.org/jira/issues/?jql=project%20%3D%20CASSPYTHON%20ORDER%20BY%20key%20DESC";
+changelog =
"https://github.com/apache/cassandra-python-driver/blob/trunk/CHANGELOG.rst";
+
+[tool.setuptools.packages.find]
+include = ['cassandra', 'cassandra.io', 'cassandra.cqlengine',
'cassandra.graph',
+'cassandra.datastax', 'cassandra.datastax.insights',
'cassandra.datastax.graph',
+'cassandra.datastax.graph.fluent', 'cassandra.datastax.cloud',
+"cassandra.column_encryption"]
+
+[tool.cassandra-driver]
+build-extensions = true
+build-murmur3-extension = true
+build-libev-extension = true
+build-cython-extensions = true
+libev-includes = []
+libev-libs = []
Review Comment:
I've actually gone back and forth on this very point. I originally
preserved the "libdirs" usage from the original but in my opinion that name is
inconsistent with "libev-includes". In each case we're identifying the
directories where a given type of file can be found; "libev-includes" defines
the directory where headers can be found while "libev-libs" defines the
directories were libs can be found. If one wanted to be pedantic one could say
that we're actually identifying the _directory_ containing the lib while
"libev-libs" sounds like we're pointing out the path to the lib itself... but,
again, this usage is inconsistent with "libev-includes".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
