arvindKandpal-ksolves commented on PR #4628: URL: https://github.com/apache/cassandra/pull/4628#issuecomment-3940014244
Hi @maurerle, thanks for the review! To answer your questions: 1. **Where it's needed:** It's inside the bundled Datastax driver (`lib/cassandra-driver-internal-only-3.29.0.zip`). When `libev` C-extensions aren't present, the driver explicitly defaults to `AsyncoreConnection` (`cassandra/io/asyncorereactor.py`), which causes the crash on Python 3.12+. 2. **Migrating to asyncio:** Yes, migrating to `asyncio` is definitely the right midterm approach. For this PR, vendoring `pyasyncore` is just a safe, immediate fix that avoids manually patching the upstream third-party driver. We can easily drop this dependency in the future once the bundled driver is updated upstream to use `asyncio` by default. 3. **Older versions:** Exactly! I verified it locally with Python 3.9 and 3.11; they seamlessly use the stdlib version without any issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
