arvindKandpal-ksolves commented on PR #4628: URL: https://github.com/apache/cassandra/pull/4628#issuecomment-3940740179
Hi @maurerle, You raise a very valid concern. The "experimental" docstring in that file seems to be a relic from the Python 3.4/3.5 era (as the comments mention 3.4.6/3.5.1 compatibility). While the underlying `asyncio` library is rock-solid in modern Python (3.8+), the driver's specific implementation of `AsyncioReactor` hasn't been heavily vetted against all `cqlsh` edge cases. Since I haven't thoroughly tested how `AsyncioReactor` handles things like heavy `COPY FROM/TO` operations, background paging, or `SIGINT` (Ctrl+C) handling in `cqlsh`, switching the core event loop right now feels like a high-risk change. Because of this unknown risk, I think vendoring `pyasyncore` is the safest, lowest-impact solution for this specific PR to restore Python 3.12/3.13 support immediately. I'd be happy to open a follow-up JIRA ticket to properly configure, benchmark, and test `AsyncioReactor` as the default for `cqlsh` so we can eventually drop this polyfill. Does this sound like a safe path forward? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
