Copilot commented on code in PR #1279: URL: https://github.com/apache/cassandra-python-driver/pull/1279#discussion_r2919867062
########## docs/installation.rst: ########## @@ -217,10 +217,16 @@ dependencies, then use install-option:: Supported Event Loops ^^^^^^^^^^^^^^^^^^^^^ -For Python versions before 3.12 the driver uses the ``asyncore`` module for its default -event loop. Other event loops such as ``libev``, ``gevent`` and ``eventlet`` are also -available via Python modules or C extensions. Python 3.12 has removed ``asyncore`` entirely -so for this platform one of these other event loops must be used. +The ``asyncore`` and ``libev`` event loops are proven production-grade event loops. Python 3.12 removed +asyncore from the runtime but this event loop can still be used in newer versions of Python via the Review Comment: In this paragraph, `asyncore` is mentioned without literal formatting while other module names are consistently marked up (e.g., ``asyncore`` / ``libev``). For consistency and to avoid Sphinx formatting drift, wrap this `asyncore` occurrence in double backticks. ```suggestion ``asyncore`` from the runtime but this event loop can still be used in newer versions of Python via the ``` ########## pyproject.toml: ########## @@ -6,7 +6,7 @@ requires = ["setuptools", "Cython>=3.0", "tomli"] name = "cassandra-driver" description = "Apache Cassandra Python Driver" version = "3.30.0" -dependencies = ['geomet>=1.1'] +dependencies = ['geomet>=1.1', "Deprecated"] Review Comment: `Deprecated` is added as a new runtime dependency, but it is unversioned while the existing core dependency (`geomet>=1.1`) uses a lower bound. Please add an explicit version specifier for `Deprecated` (at least a tested minimum), and ensure the dependency lists used for manual/test installs (e.g., `requirements.txt` referenced by docs and `test-requirements.txt`) are kept in sync so `from deprecated import deprecated` doesn't fail in those workflows. ```suggestion dependencies = ['geomet>=1.1', "Deprecated>=1.2.0"] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
