absurdfarce commented on code in PR #1279: URL: https://github.com/apache/cassandra-python-driver/pull/1279#discussion_r2927533712
########## docs/installation.rst: ########## @@ -217,10 +217,16 @@ dependencies, then use install-option:: Supported Event Loops ^^^^^^^^^^^^^^^^^^^^^ -For Python versions before 3.12 the driver uses the ``asyncore`` module for its default -event loop. Other event loops such as ``libev``, ``gevent`` and ``eventlet`` are also -available via Python modules or C extensions. Python 3.12 has removed ``asyncore`` entirely -so for this platform one of these other event loops must be used. +The ``asyncore`` and ``libev`` event loops are proven production-grade event loops. Python 3.12 removed +asyncore from the runtime but this event loop can still be used in newer versions of Python via the Review Comment: I disagree with this suggestion for two reasons. First, I prefer the idea of highlighting the first usage of a name and then leaving all other subsequent usages to be rendered as regular text. Second (and perhaps more importantly): the second usage refers to the asyncore package in the Python runtime and not the asyncore event loop built on that package. They are two different things and using the same formatting to indicate the would confuse the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
