Aklakan commented on code in PR #2822:
URL: https://github.com/apache/jena/pull/2822#discussion_r1845065044
##########
jena-integration-tests/src/test/java/org/apache/jena/test/rdfconnection/TestRDFConnectionRemote.java:
##########
@@ -228,11 +230,27 @@ public void non_standard_syntax_update_remote_3c() {
/** Standard update syntax with substitution should work. */
@Test
public void standard_syntax_update_remote_1a() {
+ RDFNode FALSE = ResourceFactory.createTypedLiteral(false);
try ( RDFConnection conn =
RDFConnectionRemote.service(server.datasetURL("/ds")).parseCheckSPARQL(false).build()
) {
conn.newUpdate()
- .update("INSERT DATA { <a> <b> <c> }")
- .update("INSERT DATA { <x> <y> <z> }")
- .substitution("foo", RDF.type).build();
+ .update("INSERT { <a> <b> <c> } WHERE { FILTER(?foo) }")
+ .update("INSERT { <x> <y> <z> } WHERE { FILTER(?foo) }")
+ .substitution("foo", FALSE)
+ .build()
+ .execute();
+ }
+ }
+
+ /** Standard update syntax with substitution should work when comments are
involved. */
+ @Test
+ public void standard_syntax_update_remote_2b() {
Review Comment:
Strictly speaking, this additional test case could go into a separate
commit. It tests for an oversight I introduced with #2580 where update strings
were joined on the semicolon without a preceding newline. In such cases,
joining update strings that ended on a comment would produce syntax errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
