Aklakan commented on code in PR #2822:
URL: https://github.com/apache/jena/pull/2822#discussion_r1845528581
##########
jena-arq/src/main/java/org/apache/jena/sparql/engine/iterator/QueryIteratorBase.java:
##########
@@ -70,7 +70,7 @@ protected QueryIteratorBase(AtomicBoolean cancelSignal) {
}
private boolean requestingCancel() {
- return requestingCancel != null && requestingCancel.get() ;
+ return (requestingCancel != null && requestingCancel.get()) ||
Thread.interrupted() ;
Review Comment:
The additional interrupted check is needed in order to cleanly stop the
Fuseki server in `TestSPARQLProtocolTimeout` which extends
`AbstractFusekiTest`: When shutting down the Fuseki server, Jetty attempts to
stop running the remaining threads via interruption. However, so far this flag
was not picked up by the `QueryIterator` machinery, causing jetty to abandon
the thread and log the warning from
`org.eclipse.jetty.util.thread.QueuedThreadPool`:
```
17:27:10 WARN QueuedThreadPool :: Couldn't stop
Thread[qtp1495161082-24,5,main]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
