Norm Jacobs wrote:
>
> I have put a codereview for the changes necessary to implement
>
> LSARC/2007/316 ImageMagick, a2ps, and psutils migration from
> /usr/sfw to /usr
>
> at http://cr.opensolaris.org/~jacobs/2007-06-01_sfwnv/webrev/
I assume the link should really be just ...
http://cr.opensolaris.org/~jacobs/2007-06-01_sfwnv
this looks okay to me.
Minor comment ...
usr/src/tools/install-proto
line 149
- the 'chown; is commented out, doesn't that make the rest
of the 'if' statement (143 to 150) redundant?
Paul
>
> The ARC case is not yet approved, so there may be some change, but this
> codereview contains the changes that migrate ImageMagick, a2ps, and
> psutils out of /usr/sfw and upgrade ImageMagick to 6.3.4. In this
> workspace, I am introducing two new tools that can be used during the
> 'install' phase of building bits in the SFW gate. The first tool is a
> replacement for install(1b)/install-sh, that will always install bits in
> the proto area, regardless of whether or not DESTDIR works. It will
> also perform gate specific post processing of the files it installs.
> The second tool will apply attributes of entries in package prototype
> files to the proto area. With these tools, it should no longer be
> necessary to hand craft an install-sfw script to copy most bits to the
> proto area.
>
> If anyone is interested, I also have a Perl script that eases the pain
> and suffering involved in generating reasonable package prototype (and
> pkginfo) files for packaging bits in the SFW gate. The script uses a
> combination of sources and rules to create a first stab at a package.
> The results should be reviewed, but it beats doing this by hand or even
> with pkgproto.
>
> These additional tools should also be able to streamline the work
> necessary to update/add bits in the Companion.
>
> As always, constructive comments/questions are welcomed if not encouraged.
>
> -Norm
>
>
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>
