Hi,
Some time has passed since we first time used that patch in our
installation. Thereafter we have realized that this kind of patch is not
the best solution for websubmit_functions in general (got that in mind
while dealing with the readme). Let me explain that:
In websubmit you have to declare the functions to be added into the
steps of websubmit. i.e. have a look on the Functions of the "SBI"
Submission of the "DEMOTHE" Document Type
("CFG_SITE_URL/admin/websubmit/websubmitadmin.py/doctypeconfiguresubmiss
ionfunctions?doctype=DEMOTHE&action=SBI&viewSubmissionFunctions=view+fun
ctions" ). Any use of CFG_WEBSTYLE_TEMPLATE_SKIN would mean, that the
defined functions would not be used for submission anymore. From the
point of view of the websubmit_admin_interface this looks somehow
confusing.
therefore the websubmit_functions are not the best place for using the
CFG_WEBSTYLE_TEMPLATE_SKIN variable. Adding a completely new function
would be a better solution in that place.
Best regards,
Tomek
>-----Original Message-----
>From: Tibor Simko [mailto:tibor.si...@cern.ch]
>Sent: Wednesday, June 20, 2012 5:44 PM
>To: Pazera, Tomasz
>Cc: project-invenio-devel@cern.ch; hgf-invenio-dev (alias for:
Mailmaster,
>Mailinglist Management)
>Subject: Re: [hgf-dev] Re: CFG_WEBSTYLE_TEMPLATE_SKIN
>
>On Mon, 18 Jun 2012, Pazera, Tomasz wrote:
>>>The changes sound useful. However, can you please submit a clean
>>> patch?
>>
>> Sure. Attached you`ll find the patch. It was created with "diff
>> -Naur". I have tested it with the current version of invenio master
>> (commit: 7dbf1735d4742551678dd1ea0e1e0ccd4cf342cb).
>
>Looks good.
>
>Since this would be the first time the skin variable is used for
>something else than, err, skinning the output, we have to document it
>carefully. Can you please add a short paragraph going like:
>
> Please note that CFG_WEBSTYLE_TEMPLATE_SKIN variable is also
> respected by WebSubmit, in that WebSubmit will try to use the end
> submission functions with names ending by ``_<skin>.py'', such as
> Send_Modify_Mail_Ithaca.py, if such a file exists. If it does not
> exist, WebSubmit will fall back to using default functions, such as
> Send_Modify_Mail.py that are coming with stock Invenio.
>
>in corresponding places in the documentation?
>
> modules/webstyle/doc/admin/webstyle-admin-guide.webdoc
> modules/websubmit/doc/admin/websubmit-admin-guide.webdoc
>
>And possibly an ultra short note to `invenio.conf' pointing to this
>fact.
>
>Best regards
>--
>Tibor Simko
