Approve and auto merge are different. Auto merge is another value of the merge button, next to squash etc.
Le mar. 22 déc. 2020 à 16:59, Bjoern Rabenstein <bjo...@rabenste.in> a écrit : > On 16.12.20 21:33, Julien Pivotto wrote: > > > > Can we enable the new github feature, auto-merge, in prometheus > > repositories? > > > > It waits for everything to be green before merging. > > Auto-merge assumes that all tests green and one valid approval means > "please merge". But I don't think that's true. I often approve a PR to > express "looks good to me but others might still chime in". That could > be the maintainer of the repo (or some other person specifically > qualified to review the PR). Those people should have the final call. > > Or in other words: Having approval and merge as separate > human-initiated steps models the semantics just right, IMHO. > > -- > Björn Rabenstein > [PGP-ID] 0x851C3DA17D748D03 > [email] bjo...@rabenste.in > > -- > You received this message because you are subscribed to the Google Groups > "Prometheus Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to prometheus-developers+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/prometheus-developers/20201222155935.GL17627%40jahnn > . > -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAFJ6V0oxo999je9-7HCbHY6OOYARPyrcyAd%2BEJMrydMP-%3D9vvw%40mail.gmail.com.
