*sigh* It looks like the version at appspot.com isn't GA+ enabled, so I sign in and it thinks I'm not signed in. Anyhow, a few comments:
Since it's generated by configure.ac, do you need it in bin_SCRIPTS? I think that might cause it to get looked at twice. You should pretty much always do a set -e at the top of a shell script to catch errors early on. *73* if test "@prefix@" != /usr -a "@prefix" != / -a "@prefix" != ""; then Should those all be @pre...@? Also, I think test -a might be a bashism in this case. From a handy cheat sheet on bashisms (https://wiki.ubuntu.com/DashAsBinSh): While dash supports most uses of the -a and -o options, they have very confusing semantics even in bash and are best avoided. Commands like the following: [ \( "$foo" = "$bar" -a -f /bin/baz \) -o ! -x /bin/quux ] should be replaced with: (([ "$foo" = "$bar" ] && [ -f /bin/baz ]) || [ ! -x /bin/quux ]) Same for this line: *79* if test $full_library = true -o $explicit_library = false; then Jeff Bailey >|< Google, Inc. >|< +1 514 670-8754 On Wed, Jul 29, 2009 at 9:23 PM, <ken...@google.com> wrote: > Reviewers: jeffbailey, > > Description: > This seems needed due to confusion about dependencies, pthreads, etc. > I'm not entirely familiar with the conventions for these scripts, > though. Did I do it right? > > Please review this at http://codereview.appspot.com/98071 > > Affected files: > M Makefile.am > M configure.ac > A protobuf-config.in > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to protobuf@googlegroups.com To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/protobuf?hl=en -~----------~----~----~----~------~----~------~--~---
