I wired in allowSkip in a very minimal way just to restore the ability to force the old behaviour. It would be a fairly trivial to change the name of course, however it appears there are a bunch of other related changes that go along with it, e.g. adding a bunch of accessors and fixing the error behavior. Currently if you put in require authentication the java sasl layer will simply die with a TransportException if it sees a regular AMQP header, and the tests appear to expect something more graceful.
I stopped there because I noticed a bunch of other unimplemented stuff and I wasn't sure how deep the bottom of the rabbit hole was. --Rafael On Mon, Jul 6, 2015 at 11:11 AM, Andrew Stitcher <astitc...@redhat.com> wrote: > On Mon, 2015-07-06 at 10:56 -0400, Rafael Schloming wrote: > > On Mon, Jul 6, 2015 at 9:52 AM, Robbie Gemmell <robbie.gemm...@gmail.com > > > > wrote: > > > > > Is this change allowing clients to skip the SASL layer when connecting > > > to servers that have enabled the SASL layer? If so, how is the new > > > default behaviour disabled? > > > > > > > Yes, it was necessary to allow the tests to pass. > > > > > > > The existing but unimplemented 'allowSkip' method previously intended > > > to enable such behaviour still doesn't do anything, so is there a way > > > to require clients use a SASL layer as would have been previously > > > after enabling SASL for a proton-j (and in the past a proton-c) > > > server? > > > > > > > Ah, I didn't notice that. Thanks for pointing it out. I'll wire it up and > > cross my fingers that the tests still pass. > > Allow_skip is no longer present in the C API it is replaced with the > require_auth (now on the transport object) API. > > So it would make more sense to implement that and remove allow_skip. > > > > > --Rafael > > >
