GitHub user hekonsek opened a pull request:
https://github.com/apache/qpid-proton/pull/65
Schema parsing should not be so greedy
Hi,
Current address schema parser doesn't work if `://` string is included in a
path. The reasons to include `://` in a path are as follows:
- it is not against AMQP address specification
- ActiveMQ AMQP module uses [1] `topic://`prefix to indicate that message
should be dispatched to broker topic, not queue (and other broker
implementations could do the same)
So to connect to ActiveMQ's topic named `topicname`, you could use the
following AMQP address - `host:423/topic://topicname` . The problem with
current `Address` implementation is that it will interpret `://` in `topic://`
as a schema separator.
Since `://` is optional in address and the only two acceptable schemas are
`amqp` and `ampqs`, I think we should narrow schema parsing to those two values.
What do you think?
[1] http://activemq.apache.org/amqp.html
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hekonsek/qpid-proton address-schema-parsing
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/65.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #65
----
commit 3ac4e79a54ba4b88bcbc8eaedcc281f5fd50d5e9
Author: Henryk Konsek <[email protected]>
Date: 2016-02-05T11:43:39Z
Schema parsing should not be so greedy.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
