Github user gemmellr commented on the pull request:

    https://github.com/apache/qpid-proton/pull/65#issuecomment-184320477
  
    I hadn't got round to looking at this closely but was likely just going to 
apply it if nothing obvious came up, and probably wouldnt have considered the 
above.
    
    As per the diff, doesnt seem like java Messenger is using the native URL 
bits to parse its URL-like strings, and I don't see anything in there handling 
special char encodings, though I guess it could be hiding elsehwere (I don't 
really know the Messenger bits at all). It does kinda looks like whats there at 
present might accept the topic:// in the path if a scheme is given before it in 
the string, but I haven't tried that.
    
    The idea that the schemes used should be looked for seems sensible, though 
perhaps other values should be rejected if that were to be done, but then it 
wouldn't play nice with without encoding special chars or again having the 
actual scheme present at the start.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to