Ok, I was on crack when I wrote that last message. The issue really is that Ajax.Requests's _complete doesn't get reset to false between calls. I wasn't able to produce a failing test, but moving the initialization of _complete into the initialize method fixes the issue for me. I've submitted a patch: http://dev.rubyonrails.org/ticket/9226
-b On Aug 8, 1:40 pm, Brad Greenlee <[EMAIL PROTECTED]> wrote: > I recently attempted to upgrade Prototype on our Rails project from > 1.5.0_rc0 to 1.5.1.1 and RJS stopped working for us. I traced the > problem down to this change: > > http://dev.rubyonrails.org/changeset/5574 > > It looks like _complete can only be set to true in > respondToReadyState(4) ("Complete"), and that appears to only be > called from this line in onStateChange: > > if (readyState > 1 && !((readyState == 4) && this._complete)) > this.respondToReadyState(this.transport.readyState); > > So I'm not seeing how that can ever be called (and it isn't, for me). > Reverting the line to: > > if (readyState > 1) > this.respondToReadyState(this.transport.readyState); > > fixes the issue, but apparently breaks synchronous requests in Safari. > > Since this change has been out for a while, I suspect I'm doing > something wrong on my end, but I haven't been able to determine what. > Any enlightenment? > > Cheers, > > Brad --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Prototype: Core" group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~----------~----~----~----~------~----~------~--~---
