Follow-up Comment #7, patch #6650 (project pspp):

It looks good.

But I think it can be simplified by having the 
struct hsh_table , struct moments1, and the struct variable array (and
possibly other things) all encapsulated into one single struct which gets
passed to covariance_accumulator_to_matrix, covariance_create and
covariance_acculumlate.  

This would make the calling code (such as glm.q) a lot simpler.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?6650>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
pspp-dev mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/pspp-dev

Reply via email to