Follow-up Comment #10, patch #6650 (project pspp):
It looks a lot simpler.
Some things that occurred to me:
1. I'm confused that covariance_matrix.h now has a _init and a _create
function. Aren't they the same thing? Similarly there is both a _destroy and
a _free function.
2. The non-static functions in covariance_matrix.c could all do with
comments.
3. You can simplify covariance_accumulator_to_matrix by having it take a
(struct covariance_matrix *) in place of the existing first 4 variables. This
should also avoid a compiler warning.
4. In struct covariance_matrix, the member n_data is allocated and values are
assigned to it. But so far as I can tell, these values are never used. Is
this variable necessary?
5. In glm.q (run_glm) I think it would be easier to understand if some of the
variables' scope was reduced. Eg: move cov, n_data, model etc into the stack
frame beginning "if (n_indep > 0) {"
6. Again in run_glm, the first reference to n_data is n_data++, but n_data
has never been initialised.
7. What should I pass to argument 2 of covariance_matrix_compute when
computing a simple covariance matrix with no categorical variables involved?
Is zero appropriate?
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?6650>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
pspp-dev mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/pspp-dev
