Remy Bohmer wrote:
> If the ptxdist project is build from a Source Control Management tool

brrr..which one?

> that makes files read-only, then ptxdist fails when it wants to
> overwrite the kernel-config after the kernel-old-config step.
> 
> It is not a real error, the oldconfig has succeed, so just print
> a warning about the read-only file instead of fail completely.

good catch, fix the thing mentioned below and add my Acked-by.

> Signed-off-by: Remy Bohmer <li...@bohmer.net>
> ---
>  rules/kernel.make |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/rules/kernel.make b/rules/kernel.make
> index 9477502..2bca568 100644
> --- a/rules/kernel.make
> +++ b/rules/kernel.make
> @@ -125,7 +125,11 @@ ifdef KERNEL_INITRAMFS_SOURCE_y
>  endif
>  
>       @$(call ptx/oldconfig, KERNEL)
> -     @cp "$(KERNEL_DIR)/.config" "$(<)"
> +     @if [ -w $(KERNEL_CONFIG) ]; then \
> +             cp "$(KERNEL_DIR)/.config" "$(<)"; \
> +      else \
> +             echo "WARNING: $(KERNEL_CONFIG) is Read-only, not updating it!" 
> 1>&2; \

please use "$(<)" instead of "$(KERNEL_CONFIG)"

> +      fi
>  
>  #
>  # Don't keep the expanded path to INITRAMS_SOURCE in $(KERNEL_CONFIG),

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Reply via email to