2010/5/28 Marc Kleine-Budde <m...@pengutronix.de>: > Remy Bohmer wrote:
> good catch, fix the thing mentioned below and add my Acked-by. All comments reworked and updated patch has been reposted. Thanks. Kind regards, Remy > >> Signed-off-by: Remy Bohmer <li...@bohmer.net> >> --- >> rules/kernel.make | 6 +++++- >> 1 files changed, 5 insertions(+), 1 deletions(-) >> >> diff --git a/rules/kernel.make b/rules/kernel.make >> index 9477502..2bca568 100644 >> --- a/rules/kernel.make >> +++ b/rules/kernel.make >> @@ -125,7 +125,11 @@ ifdef KERNEL_INITRAMFS_SOURCE_y >> endif >> >> @$(call ptx/oldconfig, KERNEL) >> - @cp "$(KERNEL_DIR)/.config" "$(<)" >> + @if [ -w $(KERNEL_CONFIG) ]; then \ >> + cp "$(KERNEL_DIR)/.config" "$(<)"; \ >> + else \ >> + echo "WARNING: $(KERNEL_CONFIG) is Read-only, not updating >> it!" 1>&2; \ > > please use "$(<)" instead of "$(KERNEL_CONFIG)" > >> + fi >> >> # >> # Don't keep the expanded path to INITRAMS_SOURCE in $(KERNEL_CONFIG), > > Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Industrial Linux Solutions | Phone: +49-231-2826-924 | > Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | > Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | > > > -- > ptxdist mailing list > ptxdist@pengutronix.de > > -- ptxdist mailing list ptxdist@pengutronix.de
