Remy Bohmer wrote:
> From: Bart vdr. Meulen <bartvdrmeu...@gmail.com>
> 
> Adds the parted package to ptxdist
> 
> We add version 1.8.7 instead of the newer 2.2 since 1.8.7 is the
> last GPLv2 version. Anything newer is GPLv3
> 
> Signed-off-by: Bart vdr. Meulen <bartvdrmeu...@gmail.com>

Remy, please add, if your're sending the patches, your S-o-b below.

> ---
>  rules/parted.in   |   13 ++++++++++
>  rules/parted.make |   70 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 83 insertions(+), 0 deletions(-)
>  create mode 100644 rules/parted.in
>  create mode 100644 rules/parted.make
> 
> diff --git a/rules/parted.in b/rules/parted.in
> new file mode 100644
> index 0000000..b5161f4
> --- /dev/null
> +++ b/rules/parted.in
> @@ -0,0 +1,13 @@
> +## SECTION=shell_and_console
> +config PARTED
> +     tristate
> +     prompt "parted"
> +     select GETTEXT
> +     select READLINE
> +     select E2FSPROGS
> +     select NCURSES
> +     help
> +       The GNU Parted program allows you to create, destroy, resize, move,
> +          and copy hard disk partitions. Parted can be used for creating 
> space
> +          for new operating systems, reorganizing disk usage, and copying 
> data
> +          to new hard disks.

nitpick: for help text the preferred style is one tab + two spaces.

> diff --git a/rules/parted.make b/rules/parted.make
> new file mode 100644
> index 0000000..5de39e7
> --- /dev/null
> +++ b/rules/parted.make
> @@ -0,0 +1,70 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2010 by Bart vdr. Meulen <bartvdrmeu...@gmail.com>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_PARTED) += parted
> +
> +#
> +# Paths and names
> +#
> +# versions newer than 1.8.7 are GPLv3 and as such not preferred
> +PARTED_VERSION       := 1.8.7
> +PARTED               := parted-$(PARTED_VERSION)
> +PARTED_SUFFIX        := tar.gz
> +PARTED_URL   := http://ftp.gnu.org/gnu/parted/$(PARTED).$(PARTED_SUFFIX)

please use: $(PTXCONF_SETUP_GNUMIRROR)

> +PARTED_SOURCE        := $(SRCDIR)/$(PARTED).$(PARTED_SUFFIX)
> +PARTED_DIR   := $(BUILDDIR)/$(PARTED)
> +PARTED_LICENSE       := GPLv2
> +
> +# 
> ----------------------------------------------------------------------------
> +# Get
> +# 
> ----------------------------------------------------------------------------
> +
> +$(PARTED_SOURCE):
> +     @$(call targetinfo)
> +     @$(call get, PARTED)
> +
> +#
> +# autoconf
> +#
> +PARTED_CONF_TOOL     := autoconf
> +PARTED_CONF_OPT      := $(CROSS_AUTOCONF_USR) \
> +     --disable-Werror

nitpick please move the $(CROSS_AUTOCONF_USR) in a seperate line

> +
> +# 
> ----------------------------------------------------------------------------
> +# Target-Install
> +# 
> ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/parted.targetinstall:
> +     @$(call targetinfo)
> +
> +     @$(call install_init,  parted)
> +     @$(call install_fixup, parted,PACKAGE,parted)
> +     @$(call install_fixup, parted,PRIORITY,optional)
> +     @$(call install_fixup, parted,VERSION,$(PARTED_VERSION))
> +     @$(call install_fixup, parted,SECTION,base)
> +     @$(call install_fixup, parted,AUTHOR,"Bart vdr. Meulen 
> <bartvdrmeu...@gmail.com>")
> +     @$(call install_fixup, parted,DEPENDS,)
> +     @$(call install_fixup, parted,DESCRIPTION,missing)
> +
> +     @$(call install_copy, parted, 0, 0, 0755, -, /usr/sbin/parted)
> +     @$(call install_copy, parted, 0, 0, 0755, -, /usr/sbin/partprobe)
> +
> +     @$(call install_copy, parted, 0, 0, 0644, -, 
> /usr/lib/libparted-1.8.so.7.0.0 )
> +     @$(call install_link, parted, libparted-1.8.so.7.0.0, 
> /usr/lib/libparted-1.8.so.7)
> +     @$(call install_link, parted, libparted-1.8.so.7.0.0, 
> /usr/lib/libparted.so)
> +     @$(call install_finish, parted)
> +
> +     @$(call touch)
> +
> +
> +# vim: syntax=make

looks quite good. Fix it and add my Acked-by.

cheers, Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Reply via email to