Stephan Linz wrote:
> Am Donnerstag, 5. August 2010, um 08:22:30 schrieb Marc Kleine-Budde:
>> Stephan Linz wrote:
>>> Signed-off-by: Stephan Linz <l...@li-pro.net>
>> applied to master
>>
>> tnx, Marc
>>
>>> ---
>>>  generic/etc/inetd.conf.d/ftpd |    1 +
>>>  rules/busybox.in              |    7 +++++++
>>>  rules/busybox.make            |    4 ++++
>>>  3 files changed, 12 insertions(+), 0 deletions(-)
>>>  create mode 100644 generic/etc/inetd.conf.d/ftpd
>>>
>>> diff --git a/generic/etc/inetd.conf.d/ftpd
>>> b/generic/etc/inetd.conf.d/ftpd new file mode 100644
>>> index 0000000..d80c851
>>> --- /dev/null
>>> +++ b/generic/etc/inetd.conf.d/ftpd
>>> @@ -0,0 +1 @@
>>> +ftp stream tcp nowait root /usr/sbin/ftpd ftpd -w -S /tmp
>>                                                   ^^^^^^^^^^
>>
>> btw what's the meaning of this options?
> 
> An excerpt from [BB]/usage.src.h:
> -w      Allow upload
> -S      Log to syslog
> 
> The more I think about this options the more I think we can run into some 
> runtime errors. Because the -w option is optional in busybox. It would be 
> better to remove the -w option here in this global file, or not?

Makes sense. As I've already applied the patch, make an incremental one.

It it works something like this plus a comment about -w would be nice
# comment
ftp stream tcp nowait root /usr/sbin/ftpd ftpd -S /tmp #-w

cheers, Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Reply via email to