On Fri, Jul 27, 2018 at 11:55:29AM +0200, Alexander Dahl wrote: > Am Freitag, 27. Juli 2018, 11:42:42 CEST schrieb Roland Hieber: > > On Fri, Jul 27, 2018 at 10:59:13AM +0200, Alexander Dahl wrote: > > > + $(GLOBAL_LARGE_FILE_OPTION) \ > > > > > > --enable-optimized \ > > > --disable-profiling \ > > > > > > - $(GLOBAL_LARGE_FILE_OPTION) \ > > > + --$(call ptx/wwo, PTXCONF_GLOBAL_LARGE_FILE)-largefiles \ > > > > Hmm. Why are you adding both GLOBAL_LARGE_FILE_OPTION and > > PTXCONF_GLOBAL_LARGE_FILE? Are those two independent kconfig options > > (and if yo, why)? Does the configure script respect both of them? I > > guess this should be mentioned in the commit message :-) > > I don't know why monit has two options for the same thing. The doc output > from > ./configure --help contains this: > > --disable-largefile omit support for large files > > and > > --without-largefiles disable large files support (default: enabled) > > The script configure_helper.py complains about it, I am not familiar with > autotools, so I can not judge what monit tries to do here. Because this is > not > the first time, I would guess monit upstream has broken autotools files? > Maybe > someone with more experience on that can say which option of those is used?
I checked to configure.ac. Setting both like this is correct. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de
