On 06/10/2010 03:35 PM, [email protected] wrote:
On 10/06/2010, at 10:42 PM, Jaromir Hradilek <[email protected]> wrote:
On 06/10/2010 12:56 AM, Jeffrey Fearn wrote:
Joshua Wulf wrote:
Another thing I notice is that publican build takes --langs as an
argument, while publican package takes --lang.
Is this because "package" can only do one language at a time, while
"build" can do multiple?
This is correct.
Cheers, Jeff.
That makes sense to me. However, did you consider allowing both --lang
and --langs interchangeably? I mean, it is perfectly OK to document
only one of them where appropriate, but it will definitely spare us
all some otherwise easily avoidable errors.
Feel free to submit a patch :-)
See the attachment! ;-) (Created by typing `diff publican/bin/publican
publican/bin/publican.orig > publican.diff' in the root directory of the
publican's latest SVN snapshot.)
However, I didn't have much time to really familiarize myself with the
source code, so there is probably a smarter way to do this.
--
Jaromir Hradilek
Associate Content Author
Engineering Content Services
Red Hat Czech s. r. o.
Purkynova 99, 612 45 Brno
Phone: +420 532 294 326
160c160
< [ 'formats', 'langs', 'publish', 'embedtoc', 'distributed_set' ],
---
> [ 'formats', 'lang', 'langs', 'publish', 'embedtoc',
> 'distributed_set' ],
202c202
< 'brand', 'lang', 'type'
---
> 'brand', 'lang', 'langs', 'type'
207c207
< 'options' => [ 'name', 'lang' ],
---
> 'options' => [ 'name', 'lang', 'langs' ],
212c212
< 'lang', 'desktop', 'brew', 'scratch',
---
> 'lang', 'langs', 'desktop', 'brew', 'scratch',
222c222
< 'options' => ['langs'],
---
> 'options' => [ 'lang', 'langs' ],
234c234
< 'options' => ['lang'],
---
> 'options' => [ 'lang', 'langs'],
247c247
< 'options' => [ 'site_config', 'lang' ],
---
> 'options' => [ 'site_config', 'lang', 'langs' ],
251c251
< 'options' => [ 'site_config', 'lang' ],
---
> 'options' => [ 'site_config', 'lang', 'langs' ],
402c402
< lang => $opts{lang},
---
> lang => $opts{lang} || $opts{langs},
430c430
< lang => $opts{lang},
---
> lang => $opts{lang} || $opts{langs},
599c599,600
< if ( $opts{langs} eq 'all' ) {
---
> my $langs = $opts{langs} || $opts{lang};
> if ( $langs eq 'all' ) {
603c604
< $translater->update_po( { langs => $opts{langs} } );
---
> $translater->update_po( { langs => $langs } );
609c610,611
< $translater->po_report( { lang => $opts{lang} } );
---
> my $lang = $opts{lang} || $opts{langs};
> $translater->po_report( { lang => $lang } );
616c618
< langs => $opts{langs},
---
> langs => $opts{langs} || $opts{lang},
634c636
< { lang => $opts{lang},
---
> { lang => $opts{lang} || $opts{langs},
663a666
> my $lang = $opts{lang} || $opts{langs};
690c693
< $cvs_pkg =~ s/$LANG_PATTERN/$opts{lang}/g;
---
> $cvs_pkg =~ s/$LANG_PATTERN/$lang/g;
738c741
< my $lang = $opts{lang}
---
> my $lang = $opts{lang} || $opts{langs}
839c842
< my $lang = $opts{lang}
---
> my $lang = $opts{lang} || $opts{langs}
_______________________________________________
publican-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/publican-list
Wiki: https://fedorahosted.org/publican
