Jaromir Hradilek wrote:
On 06/10/2010 05:49 PM, Jaromir Hradilek wrote:
On 06/10/2010 03:35 PM, [email protected] wrote:
On 10/06/2010, at 10:42 PM, Jaromir Hradilek <[email protected]>
wrote:
On 06/10/2010 12:56 AM, Jeffrey Fearn wrote:
Joshua Wulf wrote:
Another thing I notice is that publican build takes --langs as an
argument, while publican package takes --lang.
Is this because "package" can only do one language at a time, while
"build" can do multiple?
This is correct.
Cheers, Jeff.
That makes sense to me. However, did you consider allowing both --lang
and --langs interchangeably? I mean, it is perfectly OK to document
only one of them where appropriate, but it will definitely spare us
all some otherwise easily avoidable errors.
Feel free to submit a patch :-)
See the attachment! ;-) (Created by typing `diff publican/bin/publican
publican/bin/publican.orig > publican.diff' in the root directory of the
publican's latest SVN snapshot.)
However, I didn't have much time to really familiarize myself with the
source code, so there is probably a smarter way to do this.
Well, the smarter way would be to add the alias directly to the
Getopt::Long options, and then make all functions use the same form, but
I did not want to disturb the semantic distinction between the singular
and plural forms in the code.
Since they parameters do not actually do the same thing ATM, your patch
needs to include:
A: Changes to the Publican::* modules to handle the option they don't
currently support, either lang or langs, they only handle one ATM.
B: Test cases to prove your changes work.
C: Update the documentation
A involves either adding an extra parameter to the functions and making
sure one of them is supplied, or modifying bin/publican to convert from
between lang and langs as required.
B involves adding new parameter combinations to publican/t/900.publican.t
C: Update the POD and maketexts in bin/publican and the User Guide.
Cheers, Jeff.
--
Jeff Fearn <[email protected]>
Software Engineer
Engineering Operations
Red Hat, Inc
Freedom ... courage ... Commitment ... ACCOUNTABILITY
_______________________________________________
publican-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/publican-list
Wiki: https://fedorahosted.org/publican
