I left some more feedback. The only substantive request is s/supermajority/two-thirds/ since supermajority can mean several things per: https://en.wikipedia.org/wiki/Supermajority
Assuming those comments are addressed, I'm +1. Thank you so much for putting this together @ipanova! On Fri, Aug 24, 2018 at 9:59 AM, Ina Panova <ipan...@redhat.com> wrote: > I tried to address all the comments and updates the PR. > > Please give another look and vote once you're ready! > > > > -------- > Regards, > > Ina Panova > Software Engineer| Pulp| Red Hat Inc. > > "Do not go where the path may lead, > go instead where there is no path and leave a trail." > > On Thu, Aug 23, 2018 at 5:54 PM, Dana Walker <dawal...@redhat.com> wrote: > >> +1 >> >> I'm a little concerned about the stated drawbacks, but even the >> alternatives can have issues, so I think this is a good place to start and >> we can amend the process later if we run into problems and/or we arrive at >> a good solution to mitigate the drawbacks. >> >> --Dana >> >> Dana Walker >> >> Associate Software Engineer >> >> Red Hat >> >> <https://www.redhat.com> >> <https://red.ht/sig> >> >> On Fri, Aug 17, 2018 at 4:13 PM, Robin Chan <rc...@redhat.com> wrote: >> >>> +1 >>> I like the clarification to the removal piece. You may accept the >>> suggestions if they are helpful. >>> >>> >>> >>> >>> On Fri, Aug 17, 2018 at 9:32 AM, David Davis <davidda...@redhat.com> >>> wrote: >>> >>>> Assuming there are no major changes to the PUP, I’ll vote +1. >>>> >>>> Thanks for putting this together. >>>> >>>> David >>>> >>>> >>>> On Fri, Aug 17, 2018 at 7:21 AM Ina Panova <ipan...@redhat.com> wrote: >>>> >>>>> PR updated, >>>>> ready for re-review. >>>>> >>>>> >>>>> >>>>> -------- >>>>> Regards, >>>>> >>>>> Ina Panova >>>>> Software Engineer| Pulp| Red Hat Inc. >>>>> >>>>> "Do not go where the path may lead, >>>>> go instead where there is no path and leave a trail." >>>>> >>>>> On Thu, Aug 16, 2018 at 1:00 PM, Ina Panova <ipan...@redhat.com> >>>>> wrote: >>>>> >>>>>> I have opened a PR for PUP-6 [0] which describes the commit bit >>>>>> assignment/revocation process. >>>>>> >>>>>> Please take a look to review and provide feedback. >>>>>> >>>>>> I'd like to call for a vote by August 28, 2018. Per PUP-1[1], are >>>>>> the voting options: >>>>>> >>>>>> +1: "Will benefit the project and should definitely be adopted." >>>>>> +0: "Might benefit the project and is acceptable." >>>>>> -0: "Might not be the right choice but is acceptable." >>>>>> -1: "I have serious reservations that need to be thought through and >>>>>> addressed." >>>>>> >>>>>> Thank you! >>>>>> >>>>>> [0] https://github.com/pulp/pups/pull/15 >>>>>> [1] https://github.com/pulp/pups/blob/master/pup-0001.md >>>>>> -------- >>>>>> Regards, >>>>>> >>>>>> Ina Panova >>>>>> Software Engineer| Pulp| Red Hat Inc. >>>>>> >>>>>> "Do not go where the path may lead, >>>>>> go instead where there is no path and leave a trail." >>>>>> >>>>> >>>>> _______________________________________________ >>>>> Pulp-dev mailing list >>>>> Pulp-dev@redhat.com >>>>> https://www.redhat.com/mailman/listinfo/pulp-dev >>>>> >>>> >>>> _______________________________________________ >>>> Pulp-dev mailing list >>>> Pulp-dev@redhat.com >>>> https://www.redhat.com/mailman/listinfo/pulp-dev >>>> >>>> >>> >>> _______________________________________________ >>> Pulp-dev mailing list >>> Pulp-dev@redhat.com >>> https://www.redhat.com/mailman/listinfo/pulp-dev >>> >>> >> >> _______________________________________________ >> Pulp-dev mailing list >> Pulp-dev@redhat.com >> https://www.redhat.com/mailman/listinfo/pulp-dev >> >> > > _______________________________________________ > Pulp-dev mailing list > Pulp-dev@redhat.com > https://www.redhat.com/mailman/listinfo/pulp-dev > >
_______________________________________________ Pulp-dev mailing list Pulp-dev@redhat.com https://www.redhat.com/mailman/listinfo/pulp-dev