Issue #17177 has been updated by Jeff McCune. Status changed from Tests Insufficient to In Topic Branch Pending Review
# Example tests Francis, I've made two small changes to your pull request as an additional commit on top of your pull request. I mention this so you're able to see what I changed and why I changed it. The first commit is just a small change that fixes some whitespace errors I found with `git diff 1.6.x --check`. The second commit adds a bit more stubbing of the `ifconfig eth0` and `ifconfig lo` system calls. These calls were returning unexpected information when run on Mac OS X, causing the examples to fail. Both of these small changes can be seen at: <https://github.com/jeffmccune/facter/compare/puppetlabs:6b9ce2e0...jeffmccune:jeff-ticket/1.6.x/17177_add_mtu_to_interfaces> I'm going to go ahead and merge this now that everything is passing and looks good. Thanks again for the contribution, I'm looking forward to the next one! -Jeff ---------------------------------------- Feature #17177: Add MTU information to interfaces https://projects.puppetlabs.com/issues/17177#change-76334 Author: Francis Gulotta Status: In Topic Branch Pending Review Priority: Normal Assignee: Jeff McCune Category: interface Target version: 1.6.x Keywords: mtu interfaces Branch: https://github.com/puppetlabs/facter/pull/345 Affected Facter version: I'd like to add the mtu label for Util::IP for linux, bsd and sunos. These platforms already provide the mtu information for each interface in commands we run. Currently ignore it. Id also like to add mtu to the list of attributes provided in interfaces.rb. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to puppet-bugs@googlegroups.com. To unsubscribe from this group, send email to puppet-bugs+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
