On May 27, 2009, at 3:43 AM, Bart Vanbrabant wrote: > >>>> I've had a quick look over the code, but for it to go in we'd >>>> need rspec tests. >> >>>> Could you possibly follow the instructions here >> >>>> http://reductivelabs.com/trac/puppet/wiki/DevelopmentLifecycle(create >>>> a feature branch, use rake mail_patches to send the code to list >>>> for >>>> review. >> >>> Yeah, I know about the tests. I ported the non-tests parts to the >>> current master. I needed to ask where tests are created at the >>> moment >>> test or spec. >> >> New tests should be done under spec. If you have examples of the >> Test::Unit tests in your 0.24.x code on your website I can have a >> look >> and try give you an example on how to approach. > > Ok, thx. Seems that I have been using spec as well. I was kind of > confused yesterday what the current tests were. I will have to over > the tests again because I changed some stuff yesterday while porting > it. > > Before I get everything 'ready' for inclusion I would like to know if > there is really interest in it. Teyo seemed to be interested but I'm > not going to complete the test suite (because it is still laking) and > then have it all rejected :-)
To what extent do you think this makes sense for inclusion? That is, did you do this as a form of research, or did you do it because you thought it provided a solution to a key shortcoming in Puppet? I'm disappointed I can't read Dutch, as I'd quite like to know what kind of research your thesis included around this topic. I haven't spent much time on theory and Puppet recently, but if someone else is I'd definitely like to take advantage of it. :) -- If there is anything the nonconformist hates worse than a conformist, it's another nonconformist who doesn't conform to the prevailing standard of nonconformity. --Bill Vaughan --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
