On Sep 12, 2009, at 2:08 AM, Brice Figureau wrote: > > On 12/09/09 1:24, Luke Kanies wrote: >> Hi all (but mostly Brice), >> >> I'm working on http://projects.reductivelabs.com/issues/2596 -- >> extracting the class/define/node classes from AST classes -- and I >> realize now that I don't need to extract them, I just need to move >> them. There's essentially no AST behaviour left in them at all, so I >> can just move them out. Except. >> >> The new AST docs stuff is still used and needed. So, I'm thinking of >> converting that to a module or something (as opposed to it being >> defined on the AST base class), so these non-AST classes can still >> provide docs in the way that the AST stuff expects. >> >> Seem reasonable? > > It seems so. > One gotcha: puppetdoc rdoc parser is not covered by unit tests (this > is > on my todo list, but since this is several pages long it won't happen > tomorrow), so we should properly test rdoc is not broken.
I've successfully pulled this into a module, but it was very much as prototype code, not production. I'm hoping I'll have a chance to finish this refactor, which would include, at the least, making this module a bit more robust. -- SCSI is *not* magic. There are fundamental technical reasons why it is necessary to sacrifice a young goat to your SCSI chain now and then. --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
