On Oct 6, 2009, at 10:05 AM, Brice Figureau wrote: > > On 6/10/09 17:29, sam wrote: >> >> >> On Oct 6, 11:00 am, Luke Kanies <[email protected]> wrote: >>> On Oct 5, 2009, at 8:56 AM, Michael Gliwinski wrote: >>> >>> >> Attached is a patch, which I thought to float to get some comments. >> I'll polish it some more and add tests. >> * autorequire all file resources using the bucket, is this the right/ >> clean way to ensure a commit/tag is done @ the end >> * Don't like the bounce of addfile from one class to the other I >> suppose ProxyClient would help >> * will factor out more common bits out of the 2 repo classes. >> * Don't like the way the filebucket resource logs dirty -> commit, >> but >> don't know how to suppress it >> * > > Naive question: shouldn't we first move the filebucket into the > inderector (ie under the REST system) before adding this feature?
Indeed - that's the short answer to most of this patch, unfortunately. -- The Internet, of course, is more than just a place to find pictures of people having sex with dogs. -- Time Magazine, 3 July 1995 --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
