On Thu, Sep 16, 2010 at 2:52 PM, Jeff McCune <[email protected]> wrote:
> On Thu, Sep 16, 2010 at 1:24 PM, Paul Berry <[email protected]> wrote: > > On Wed, Sep 15, 2010 at 11:35 AM, Luke Kanies <[email protected]> > wrote: > [snip] > > Can we count on clients of the REST API to have access to an ssl > > lib? If so, I'd be happy to drop this feature. > > If we decide to keep it, I agree that we should have separate formats > > distinguished by MIME type. The "human readable text" format would be > > solely for the benefit of REST API clients that didn't have easy access > to > > an ssl lib, and all other clients (including puppet itself) would > continue > > to use the PEM-encoded format that's already implemented today. > > I view these the PEM encoding of a certificate and the human readable > output as two entirely different things and as such should be > different methods of the API. > > If I ask for a certificate, I expect something that is a form a > certificate, e.g. the PEM encoded representation. > > As for the text, It sounds like we're talking about the human readable > output of the openssl x509 -text family of commands and what puppetca > --print does. This output is definitely not a certificate. It's > information about a certificate, or a description of a certificate. > > As a result, I would strongly recommend implementing this as a > separate and distinct "describe" action in the REST API if we support > the feature. > Sorry for being slow on the reply here--I got caught up working on the 2.6.2 release. Http only defines the methods HEAD, GET, POST, PUT, DELETE, TRACE, OPTIONS, CONNECT, and PATCH (see http://en.wikipedia.org/wiki/Hypertext_Transfer_Protocol#Request_methods), and of these, Puppet's indirector design only supports GET, PUT, and DELETE. So adding a distinct "describe" action would be difficult and nonstandard. How would you feel about using a parameter in the query string instead (e.g. "?human_readable=true")? I think that would actually be slightly easier to implement than using MIME types, considering the bugs we currently have in handling MIME types properly in Puppet (e.g. http://projects.puppetlabs.com/issues/4456). -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
