Peter Meier <[email protected]> wrote: On 08/03/2011 11:32 PM, Jacob Helwig wrote: > I didn't remember seeing a way to get the diff from the v3 API, and I > won't really be able to try things out until I get back to a real > computer. I only saw ways to get which files changed, and which commits > are part of a pull request. If you know of a way, I'd love to see it > added to the v3 API gem (octocat_herder), and the pull notification bot > itself (next branch). Both of which are up on my GitHub account ( > https://github.com/jhelwig ).
The Pull request api [0] includes a link to a diff or patch view. So my proposal would be to simply download the patch url and include this stream in the mail. Sounds feasible? If you agree on that proposal or come up with a better one I would look into hacking it into the octocat_herder. ~pete [0] http://develop.github.com/p/pulls.html -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en. I'm not sure if that particular change would be better off in the bot or the v3 API gem. My gut feeling is that it belongs in the bot, but if it makes it cleaner, and easier to do by having it in octodat_herder, then I won't complain about the API "extension" being in there. -- Sent from my phone. Please excuse my brevity. -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
