On Thu, Aug 4, 2011 at 14:09, Jeff McCune <[email protected]> wrote: > On Tue, Aug 2, 2011 at 5:57 PM, Jacob Helwig <[email protected]> wrote: >> >> The tl;dr: >> >> Our new preferred method of contributing changes is via GitHub pull >> requests, and all Puppet Labs developers will be submitting their >> changes for inclusion into the repository via pull request. > > One thing I'm still confused about is how Reviewed-by: lines should be > handled. > > Talking with the devs in the office it sounds like the person reviewing just > clicks Merge and that's sufficient for the Reviewed by line so long as the > person doing the merge is different from the person who submitted the pull > request.
Sorry we failed to communicate this well. Our "Reviewed-By" lines were mostly an internal tracking mechanism to ensure that we know who else had looked at the code, against someone being run over by a bus, or an offer to work on a tropical island, or something. When we merge through GitHub all the metadata in the repository about that gives a solid indication of who else was involved. This lets us track folks down, so you don't have to use the human added description. You are, however, welcome to do so, as always. Daniel -- ⎋ Puppet Labs Developer – http://puppetlabs.com ♲ Made with 100 percent post-consumer electrons -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
