On Sun, Aug 28, 2011 at 08:30, <wearetherob...@puppetlabs.com> wrote:
> Please review the pull request #67: (#8986) Don't su when creating SSH > authorized_keys opened by (khightower) This reverts a deliberate change made here: commit ae520057280c2454bc44c64ac1e6686bf2eb086d Author: Markus Roberts <mar...@reality.com> Date: Wed Apr 28 15:39:39 2010 -0700 Write ssh_authorized_keys as user This is a targeted fix to the issue of permissions when writing ssh authorized key files by 1) requiring that an existing users be specified on the resource and 2) doing the write as that user. It's based on Michael DeHaan's initial implementation of Luke's idea, but with a number of simplifications (mostly by testing necessary conditions as early as possible so the code isn't cluttered up with a lot of checks). The tests in this version are modified slightly to remove some additional implementation couplings that were added in master. I have not taken the time to look, in detail, at this yet, but we should consider at least the greater scope of changes that were made in that commit before we absorb this. Daniel -- ⎋ Puppet Labs Developer – http://puppetlabs.com ♲ Made with 100 percent post-consumer electrons -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com. To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.