On Sunday, November 20, 2011 at 11:25 AM, James Turnbull wrote: > Trevor Vaughan wrote: > > This was committed such that all file diffs would go into the logs. > > > > Please be very vocal about announcing this and think about turning file > > diffs off as the default. > > > > I think that most users are quite happy about being able to see diffs at > > the command line but not in the system logs since these may contain > > sensitive > > information. > > > > Also, you might want to have the --test command turn on diffs explicitly so > > that people don't have to. This would keep things working the way they are > > now by default. > > > > > Yeah I agree. The show_diff option should be off by default and added > to --test. > So this is the current behavior already. show_diff defaults to off, and we turn it on for --test and noop. Is the result here that it should not be turned on automatically for noop? > > James > > -- > James Turnbull > Puppet Labs > 1-503-734-8571 > To schedule a meeting with me: http://tungle.me/jamtur01 > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to puppet-dev@googlegroups.com > (mailto:puppet-dev@googlegroups.com). > To unsubscribe from this group, send email to > puppet-dev+unsubscr...@googlegroups.com > (mailto:puppet-dev+unsubscr...@googlegroups.com). > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > >
-- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com. To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
