-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 When I ran tests with this patch in, it was diffing to the logs and I could not turn it off.
Trevor On 11/22/2011 04:16 PM, Nick Lewis wrote: > On Sunday, November 20, 2011 at 11:25 AM, James Turnbull wrote: >> Trevor Vaughan wrote: >>> This was committed such that all file diffs would go into the logs. >>> >>> Please be very vocal about announcing this and think about turning file >>> diffs off as the default. >>> >>> I think that most users are quite happy about being able to see diffs at >>> the command line but not in the system logs since these may contain >>> sensitive >>> information. >>> >>> Also, you might want to have the --test command turn on diffs explicitly so >>> that people don't have to. This would keep things working the way they are >>> now by default. >>> >> >> >> Yeah I agree. The show_diff option should be off by default and added >> to --test. >> > So this is the current behavior already. show_diff defaults to off, and we > turn it on for --test and noop. Is the result here that it should not be > turned on automatically for noop? > >> >> James >> >> -- >> James Turnbull >> Puppet Labs >> 1-503-734-8571 >> To schedule a meeting with me: http://tungle.me/jamtur01 >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Puppet Developers" group. >> To post to this group, send email to puppet-dev@googlegroups.com >> (mailto:puppet-dev@googlegroups.com). >> To unsubscribe from this group, send email to >> puppet-dev+unsubscr...@googlegroups.com >> (mailto:puppet-dev+unsubscr...@googlegroups.com). >> For more options, visit this group at >> http://groups.google.com/group/puppet-dev?hl=en. >> >> > > - -- Trevor Vaughan Vice President, Onyx Point, Inc. email: tvaug...@onyxpoint.com phone: 410-541-ONYX (6699) pgp: 0x6C701E94 - -- This account not approved for unencrypted sensitive information -- -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAEBAgAGBQJO1GMVAAoJECNCGV1OLcypd6QH+wQvumeLlYdQSkuon/v9xPgJ 9w1RgGp3eFGj8LGqwhBCgWKJoXGCL5TXCuit3WhDT7DilZm7wgjtYZseS6i2U3BU b161N4yZd8OoLZKgpN/jrFBRiV6/FYxuuf9iTro20WdKXzwTdUOxyd5FZLqzv8nY Y0rURe01NCDQHp1v3zh48MEW45D8kU51NWf+J6dRJPnKk35SlQ1fmc//VtC8kK1O 3M6zwtikkb9m44Fy0IHhxXrnE1Cnkwed2Td2DibbFgt9v9DKo2SaRc7RGWiXc4mj 0INtKttA9A/yB7c/RHsNTDjiF26jCIFWyihqMAgs66E552jE3RHD+mNtdH56gz8= =XAvW -----END PGP SIGNATURE----- -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com. To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
<<attachment: tvaughan.vcf>>
