On Mon, May 14, 2012 at 6:19 AM, Ken Barber <k...@puppetlabs.com> wrote:
> > So when I roll back to c9386b541e9ecf6c0daffde2825bad385ea4da2b I'm > all good again. I've put in a work-around: > > c.before :each do > Puppet[:data_binding_terminus] = 'none' > end > > Which works smashingly ... but its a workaround, and should belong > elsewhere. > > My question here is - where should this be fixed now? Is this > something that needs to be put into puppet/test/test_helper.rb, or > into puppet_spec_helper.rb? I'm asking this because I wanted to know > where to raise the bug basically :-). So, after reading the rest of this thread, I'm not sure whether or not you still want/need to change the test setup code... but I thought I'd try to answer your question anyway, because I'm sure that question will come up again in the future. My hope with the puppetlabs_spec_helper stuff is that we put as *little* as possible there; it should ideally not be responsible for anything other than determining whether you are working with an old version of puppet, and, if so, trying to provide support for it. If you are working with recent versions of puppet then it should simply delegate *everything* related to test setup/teardown to the TestHelper class that you mentioned... that file lives in the same source tree as puppet, so it doesn't have to worry about cross-version compatibility. That would be a fine place to put any settings initialization for data binding, or similar functionality. -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com. To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
