On 09/17/2014 07:12 PM, Andy Parker wrote: > Adrien has put together a change to address PUP-1106 (failed > dependencies are not honored on refresh), however this is a really > thorny issue and I'd like to get some more eyes on it before > committing to the change. > > I think the original bug in redmine has the most history > (http://projects.puppetlabs.com/issues/5876) and unfortunately it > doesn't look like there was a clear decision about what the correct > behavior is. I think John's description of the semantics are pretty > good, but I find it a little hard to unravel it into what needs to change. > > Adrien's solution is to make it so that a resource *does not process > refresh events* when it is being skipped. Skipping can happen because > of failed dependencies or because the resource isn't scheduled. I'm > going to keep looking over it and will try it out some, but I think > others should kick these tires a bit as well.
Oh, the nostalgia. The issue got somewhat watered down back in the day, with questions about the semantics of refreshonly execs especially when they don't get triggered. I don't think this belongs into this discussion at all and can be regarded after the refresh madness itself is sorted out. Which this fix will. I think. There are other exciting cases in there, such as "is a resource failed if it's in sync but the refresh fails" and so forth. I feel that those are more relevant, but should probably be handled on their own. This should be possible, and I don't see that it would be contradictory for the proposed design. In other words, fixes for related issues can likely be implemented independently of merging this one. Specifically, one of the more disturbing examples from the ticket is this: http://projects.puppetlabs.com/issues/5876#note-16 This one is not fixed through the proposed change. It will need another change to the effect that a failure to refresh constitutes a resource failure as well, I assume. Which it should. But, and I repeat myself on purpose, this should be a different discussion. Cheers, Felix -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/5419DA51.1080405%40Alumni.TU-Berlin.de. For more options, visit https://groups.google.com/d/optout.
