Hi Josh, I will plan to attend the PR triage on Wed. On Thu, Nov 13, 2014 at 11:52 PM, Josh Cooper <[email protected]> wrote:
> > > On Thu, Nov 13, 2014 at 10:35 AM, Geoffrey Gardella <[email protected]> > wrote: > >> Hi Josh! >> I am with Oracle and have just been assigned to work on Puppet in >> Solaris. I am just getting oriented, but this looks like something we >> should be working on. >> > > Welcome Geoffrey, that's great news! > > Is this functionality being covered elsewhere? If not, I can open an >> internal ticket to get this covered. >> > > We merged a fix for https://tickets.puppetlabs.com/browse/PUP-3388 > recently, and I verified it worked as expected on Solaris 11.1. In the > immediate term, could you take a look and confirm? > So, it looks like the fix was ded0852 <https://github.com/puppetlabs/puppet/commit/ded0852568a679a39cf2ded7bce4007b4cb2c7c5>. I will have a look, but am still coming up to speed. Certainly the debug output below looks correct. > zpool { tstpool: > ensure => present, > mirror => ['/ztstpool/dsk1 /ztstpool/dsk2', '/ztstpool/dsk3 > /ztstpool/dsk4'] > } > > root@yscuew2s4qea3eu:~/puppet# bundle exec puppet apply zpool.pp --debug > ... > Debug: Executing '/usr/sbin/zpool create tstpool mirror /ztstpool/dsk1 > /ztstpool/dsk2 mirror /ztstpool/dsk3 /ztstpool/dsk4' > Notice: /Stage[main]/Main/Zpool[tstpool]/ensure: created > ... > root@yscuew2s4qea3eu:~/puppet# zpool status -v tstpool > pool: tstpool > state: ONLINE > scan: none requested > config: > > NAME STATE READ WRITE CKSUM > tstpool ONLINE 0 0 0 > mirror-0 ONLINE 0 0 0 > /ztstpool/dsk1 ONLINE 0 0 0 > /ztstpool/dsk2 ONLINE 0 0 0 > mirror-1 ONLINE 0 0 0 > /ztstpool/dsk3 ONLINE 0 0 0 > /ztstpool/dsk4 ONLINE 0 0 0 > > >> So far, we aren't even pushing our changes back upstream, so fixing that >> that is my first order of business. >> > > It would be great to get those fixes merged upstream. You can find us on > #puppet-dev if you need assistance with the PR process. Also, every Weds > from 10-12 PST, we hold a PR triage on google hangouts. It would be great > to catch up at next week's PR triage and talk about next steps. > Sounds good. I'm sure I will need help as I learn the ropes here. > Also the following query roughly captures the current set of open Solaris > issues: > > > https://tickets.puppetlabs.com/issues/?jql=project%20in%20(PUP%2C%20FACT%2C%20HI)%20and%20description%20~%20%27solaris%27%20and%20status%20not%20in%20(%27Resolved%27%2C%20%27Closed%27) > > It would be great if you could chime in on those tickets, and see if your > changes address some of them. > > We are also looking at moving non-core types and providers out of puppet, > and giving community subject matter experts commit access. We are actively > working on removing nagios, with the goal of establishing a pattern so that > other non-core types and providers can be moved in a similar way. I imagine > zpool could follow soon after. > This makes sense. My main concern here will be making sure that the testing/push process for our code is in place, so that we are prepared to take that on. > > >> > >> >> Cheers, >> Geoffrey >> >> >> On Monday, November 10, 2014 11:06:51 PM UTC-8, Josh Cooper wrote: >>> >>> There looks to be a bug in the current zpool provider, where if you have >>> a manifest like: >>> >>> mirror => ["disk1 disk2", "disk3 disk4"], >>> >>> Puppet will execute: >>> >>> zpool create data mirror "disk1 disk2" "disk3 disk4" >>> >>> Instead of: >>> >>> zpool create data mirror disk1 disk2 mirror disk3 disk4 >>> >>> Adam put together a PR at https://github.com/ >>> Incognito1992/puppet/compare/ticket/master/PUP-3388-zpool-mirrors, but >>> while researching it, I think this is really a regression due to >>> http://projects.puppetlabs.com/issues/16157, commit https://github.com/ >>> puppetlabs/puppet/commit/4a6853e1de083842362dc30d0842bbbb9b029f64, >>> first introduced in Puppet 3.0. >>> >>> The Oracle docs[1] seem to support that Puppet is now doing the wrong >>> thing: >>> >>> Virtual devices are specified one at a time on the command line, >>> separated by whitespace. The keywords “mirror” and “raidz” are used to >>> distinguish where a group ends and another begins. For example, the >>> following creates two root vdevs, each a mirror of two disks: >>> >>> # zpool create mypool mirror c0t0d0 c0t1d0 mirror c1t0d0 c1t1d0 >>> >>> This seems pretty straightforward, but I wanted to raise the issue here, >>> because I am not a Solaris expert, and it's been broken for awhile without >>> anyone noticing... I've submitted a PR at https://github.com/ >>> puppetlabs/puppet/pull/3299, comments welcome. >>> >>> Josh >>> >>> [1] https://docs.oracle.com/cd/E23824_01/html/821-1462/zpool-1m.html >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "Puppet Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/puppet-dev/7dd557f6-cac1-4d99-a9c5-89dfc6158b82%40googlegroups.com >> <https://groups.google.com/d/msgid/puppet-dev/7dd557f6-cac1-4d99-a9c5-89dfc6158b82%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > Josh Cooper > Developer, Puppet Labs > > *Join us at **PuppetConf 2015, October 5-9 in Portland, OR - * > http://2015.puppetconf.com. > *Register early to save 40%!* > > -- > You received this message because you are subscribed to a topic in the > Google Groups "Puppet Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/puppet-dev/kLSiWghNrvY/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/puppet-dev/CA%2Bu97umK_GEokBor_tDyrO4jG_Tv%3DnriQwD_2TYM16vuc_vxoA%40mail.gmail.com > <https://groups.google.com/d/msgid/puppet-dev/CA%2Bu97umK_GEokBor_tDyrO4jG_Tv%3DnriQwD_2TYM16vuc_vxoA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > Cheers, Geoffrey -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CAPA9Ot-ODx03ixzZf9xhS7xo9tipn_xj9jV8_P7js8GuBN5XRQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
