Heh, for some reason my brain skipped that.

Ok, that makes sense I suppose as long as people are made aware that this
is a breaking change.

Trevor

On Wed, Apr 1, 2015 at 8:17 PM, Thomas Hallgren <
thomas.hallg...@puppetlabs.com> wrote:

>  On 2015-04-02 02:12, Trevor Vaughan wrote:
>
> Agreed, but as John points out, it *was* legal (intentionally or not) so
> this is a breaking change for some people.
>
>  Being a breaking change, I would vote for backing it out until something
> can be decided that will not break existing systems.
>
>  Is there any value that current is not valid in a key that would work
> instead of a dot?
>
>   Keep in mind though, that this is not a new Hiera 1.3.x. It's not even
> 1.x. It's 2.0.0. If there is any point in time when we want to make a
> statement on what characters that are legal when declaring a key in Hiera,
> that time is now.
>
> - thomas
>
>  Thanks,
>
>  Trevor
>
> On Wed, Apr 1, 2015 at 7:58 PM, Thomas Hallgren <
> thomas.hallg...@puppetlabs.com> wrote:
>
>> On 2015-04-02 01:29, Trevor Vaughan wrote:
>>
>>> I think perhaps if the issue could be pointed out that provides for
>>> *key* interpolation on dotted values without interpolation notation, that
>>> might clear things up.
>>>
>>> Thomas' example does provide HI-14 as I read it *but* there may have
>>> been an unintended side effect that the following is a disaster for
>>> exsiting sites:
>>>
>>> my.days_up: "%{system_uptime.days}"
>>>
>>> my.days_up will try to traverse into the data structure of 'my' and will
>>> break. This is bad. Nothing should be interpolated that is not surrounded
>>> in "%{}"
>>>
>>>
>>>  I think that whether declaring a value with a dotted key is considered
>> legal or not is a separate discussion. If that's the case, then we can't
>> use dots to traverse. Not when looking up and not in interpolated
>> expressions (since that's an implicit lookup).
>>
>> - thomas
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Puppet Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to puppet-dev+unsubscr...@googlegroups.com.
>>  To view this discussion on the web visit
>> https://groups.google.com/d/msgid/puppet-dev/551C860E.7030701%40puppetlabs.com.
>>
>>
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
>  --
> Trevor Vaughan
> Vice President, Onyx Point, Inc
> (410) 541-6699
> tvaug...@onyxpoint.com
>
> -- This account not approved for unencrypted proprietary information --
>  --
> You received this message because you are subscribed to the Google Groups
> "Puppet Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to puppet-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/puppet-dev/CANs%2BFoVtQhG34cFk6BADSnQAubrWhLx6ARbmKEmGDJ9ZMTwBtw%40mail.gmail.com
> <https://groups.google.com/d/msgid/puppet-dev/CANs%2BFoVtQhG34cFk6BADSnQAubrWhLx6ARbmKEmGDJ9ZMTwBtw%40mail.gmail.com?utm_medium=email&utm_source=footer>
> .
> For more options, visit https://groups.google.com/d/optout.
>
>
>  --
> You received this message because you are subscribed to the Google Groups
> "Puppet Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to puppet-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/puppet-dev/551C8AB3.4080000%40puppetlabs.com
> <https://groups.google.com/d/msgid/puppet-dev/551C8AB3.4080000%40puppetlabs.com?utm_medium=email&utm_source=footer>
> .
>
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Trevor Vaughan
Vice President, Onyx Point, Inc
(410) 541-6699
tvaug...@onyxpoint.com

-- This account not approved for unencrypted proprietary information --

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/puppet-dev/CANs%2BFoXA2Xq_mgnzBNFQqJdo04zSbNVx8io%2BseFEQod4Zquvow%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to