On Jan 13, 7:04 pm, Daniel Pittman <dan...@rimspace.net> wrote: > Luke, I don't see a CLA for you (but I confess that I am new at the > process of checking that, so please forgive me if you have one already > and I messed up.) > > This change isn't huge, but it would be nice to get a CLA for you – > especially because I hope to steal the credit for ^W^W^W^W incorporate > more of your really great explanations into future documentation. You > do an amazing job of making things like this clear to people, and I > just hope my extra text lives up to the same standard. (We would also > love it if you sent us changes to the documentation you wrote, hint, > hint. ;) > > You can sign it through our RedMine system > athttps://projects.puppetlabs.com/contributor_licenses/sign– which > requires a login, but we can get you a faxable version if that is a > pain. > > Anyway, thanks so much for making these contributions to the list. > They are great! > > Regards, > Daniel
No problem at all - CLA (digitally) signed. I like that you're using different class include notations, my only suggestion is to comment the types of includes you're doing so people who are unfamiliar with the different methods aren't confused: #a simple class include, the class name is the same as the module name include puppet => modules/puppet/manifests/init.pp # class puppet { ... #including a class nested in a module's namespace include puppet::master => modules/puppet/manifests/master.pp # class puppet::master { ... #defines can be done the same way, note the module namespace #in the define's name. puppet::params { "example": value => 'meow' } => modules/puppet/manifests/params.pp # define puppet::params ($value) { ... #a class nested several levels deep into a module. #Note the use of the parameterised class syntax makes no difference. class { "puppet::master::awesome": } => modules/puppet/manifests/master/awesome.pp # class puppet::master::awesome { ... Lastly, I actually don't know what takes precedence over these two manifest paths or what the preferred method is (or if the second one would even work?) so maybe something about that too: modules/puppet/manifests/master.pp modules/puppet/manifests/master/init.pp -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com. To unsubscribe from this group, send email to puppet-users+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en.