Ok, I'll try to see if I can find a solution by myself meanwhile. Maybe the override should be done as you say, so, in a different fashion than the upstream patch.
Cheers On Mon, Jan 12, 2015 at 3:55 PM, Felix Frank <felix.fr...@alumni.tu-berlin.de> wrote: > On 01/12/2015 01:22 PM, Davide Ferrari wrote: >> Hello! >> >> My code is basically this commit >> >> https://github.com/vide/facter/commit/c4060af48074c372a63409d81b836b79ff5d0427 >> >> This patch works smoothly if I overwrite the files in >> /usr/lib/ruby/vendor_ruby/ > > All right, awesome. Thanks for that. > > I think the issue is that facter/util is not supposed to be pluggable > this way. Custom facts live in lib/facter/*.rb and that's the extent of > it. I may be mistaken, but it seems consistent to me that this will not > work. > > I would hope that you can build your override in a fashion to > 1. run the original resolution > 2. modify the value to add the 'label' key in the way you need > ...instead of copy-pasting the complete original fact code. > > I'd need to go code-diving to find out how one would go about this > exactly, or whether it is at all possible. Please let us know if you > manage to build something like this on your own in the meantime :-) > > Cheers, > Felix > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to puppet-users+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/puppet-users/54B3E076.5090609%40alumni.tu-berlin.de. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/CAKsfaEaoT0iJVkgpxJfoMkq6o6KmLkdM8SbEsDn5TE1tbV8EjA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
