Hi Mark, On Wed, Jul 22, 2015 at 1:01 PM, Rob Reynolds <r...@puppetlabs.com> wrote:
> Given we've discovered a bug in 3.7.5 and have recalled it for an > incorrect version of Ruby[1], it's possible this issue was limited to just > Puppet 3.7.5. Registry could be one thing that would likely have a large > effect given the amount of changes we put in to make registry work again on > Ruby 2.1.x. > > [1] > https://groups.google.com/forum/#!msg/puppet-dev/VtqadVFJKLM/e28O_so11fMJ > > On Fri, May 1, 2015 at 2:58 PM, Rob Reynolds <r...@puppetlabs.com> wrote: > >> >> >> On Fri, May 1, 2015 at 12:59 PM, Mark Wolek <markwo...@gmail.com> wrote: >> >>> C:\Users\Administrator>puppet apply --version >>> 3.7.5 >>> >>> C:/ProgramData/PuppetLabs/puppet/etc/modules >>> └─┬ puppetlabs-registry (v1.1.0) >>> └── puppetlabs-stdlib (v4.6.0) >>> >>> >>> No puppetmaster server is involved. >>> >>> Thanks! >>> >> >> It's possible we may have a bug. I created MODULES-2005[1] to follow up. >> Thanks! >> >> [1] https://tickets.puppetlabs.com/browse/MODULES-2005 >> >> >>> >>> >>> On Tuesday, April 28, 2015 at 12:38:23 PM UTC-5, Rob Reynolds wrote: >>>> >>>> >>>> >>>> On Mon, Apr 27, 2015 at 11:28 AM, Mark Wolek <mark...@gmail.com> wrote: >>>> >>>>> Thanks John! It appears to open a ticket I do so on the GitHub site by >>>>> logging in, is this correct? >>>>> >>>>> The reason for suspecting the lack of string termination is due to >>>>> what we see in the Registry GUI, which is random characters and words >>>>> after >>>>> the string, then you hit Refresh on the page, the random characters and >>>>> strings change. >>>>> >>>>> It does seem specific to a hyphen being in the string, but I will test >>>>> again to be certain. >>>>> >>>> We recently discovered that the ruby APIs for managing REG_MULTI_SZ registry values do not properly terminate wide strings. The Win32 API requires two wide NULL characters, which ruby was not doing. The ruby API would sometimes work depending on what value was in memory following the single wide NULL terminator. The puppetlabs ticket is https://tickets.puppetlabs.com/browse/MODULES-1921 and the upstream ruby bug is https://bugs.ruby-lang.org/issues/11439, which it looks like they are in the process of fixing and backporting. We've worked around the ruby issue and released a new version of the puppetlabs-registry module. You'll want version 1.1.2. > >>>> Hi Mark, >>>> What version of the registry module are you using? What version of the >>>> Puppet agent are you on? The issues you stated above were known issues that >>>> we believe we have corrected in newer versions of Puppet. >>>> >>>> We also vendor Ruby into the Puppet Installer for Windows (and we've >>>> done this almost since the first release supporting Windows), so we can >>>> usually rule out Ruby compatibilities in some respects, but not always with >>>> modules. >>>> >>>> >>>> >>>>> >>>>> Thanks! >>>>> Mark >>>>> >>>>> >>>>> On Monday, April 27, 2015 at 9:06:31 AM UTC-5, jcbollinger wrote: >>>>>> >>>>>> >>>>>> >>>>>> On Friday, April 24, 2015 at 1:52:17 PM UTC-5, Mark Wolek wrote: >>>>>>> >>>>>>> We believe this has something to do with puppet inserting strings >>>>>>> that are not null terminated, but I've had no luck at all adding >>>>>>> termination to the string... have tried single and double quoting it. >>>>>>> \x0 >>>>>>> \00 \000 so many types of termination tried but nothing seems to do the >>>>>>> trick... >>>>>>> >>>>>>> >>>>>> >>>>>> Having examined the source of the latest version of this module, I >>>>>> can tell you that Puppet relies on registry support from the Ruby >>>>>> standard >>>>>> library to handle the low-level details of registry manipulation. As far >>>>>> as I can tell, Puppet's own code does not do any parsing or processing of >>>>>> registry values that would be sensitive to a hyphen character in the >>>>>> string. Were you speculating about that being related to the problem, or >>>>>> do you in fact see different results when the array elements do not >>>>>> contain >>>>>> hyphens? >>>>>> >>>>>> I am anyway inclined to think that the problem is NOT wrong string >>>>>> termination, at least of the values you specify in your manifest, because >>>>>> Get-ItemProperty is giving you an array value in which the first element >>>>>> appears completely correct. The problem could, however, be related to >>>>>> incorrectly specifying the size of the *array* to Windows, or >>>>>> failing to provide an array terminator (I'm not much of a registry >>>>>> tinkerer, so I'm not sure which would actually be applicable). >>>>>> >>>>>> I encourage you to file a ticket against the module. I am uncertain >>>>>> whether the issue is there or in the Ruby standard library because the >>>>>> docs >>>>>> of the relevant library class suffer from the vagueness typical of Ruby >>>>>> docs, but the module maintainers are best positioned to evaluate that. >>>>>> Even if the problem turns out to be in the underlying Ruby library, it >>>>>> does >>>>>> not appear that the module's tests include any that exercise setting or >>>>>> retrieving values of type "array", and a ticket against the module >>>>>> *should* result at least in addition of such tests. >>>>>> >>>>>> >>>>>> John >>>>>> >>>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Puppet Users" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to puppet-users...@googlegroups.com. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/puppet-users/c0503ad5-5d72-48ed-868f-522491f93e78%40googlegroups.com >>>>> <https://groups.google.com/d/msgid/puppet-users/c0503ad5-5d72-48ed-868f-522491f93e78%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> >>>> >>>> -- >>>> Rob Reynolds >>>> Developer, Puppet Labs >>>> >>>> *PuppetConf 2015 <http://2015.puppetconf.com/> is coming to Portland, >>>> Oregon! Join us October 5-9.* >>>> *Register now to take advantage of the Early Adopter discount >>>> <https://www.eventbrite.com/e/puppetconf-2015-october-5-9-tickets-13115894995?discount=EarlyAdopter> >>>> * >>>> *—**save $349!* >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Puppet Users" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to puppet-users+unsubscr...@googlegroups.com. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/puppet-users/ba3115b4-43e5-49c8-9e2e-261d5f59f3f5%40googlegroups.com >>> <https://groups.google.com/d/msgid/puppet-users/ba3115b4-43e5-49c8-9e2e-261d5f59f3f5%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> >> >> -- >> Rob Reynolds >> Developer, Puppet Labs >> >> *PuppetConf 2015 <http://2015.puppetconf.com/> is coming to Portland, >> Oregon! Join us October 5-9.* >> *Register now to take advantage of the Early Adopter discount >> <https://www.eventbrite.com/e/puppetconf-2015-october-5-9-tickets-13115894995?discount=EarlyAdopter> >> * >> *—**save $349!* >> > > > > -- > Rob Reynolds > Developer, Puppet Labs > > *PuppetConf 2015 <http://2015.puppetconf.com/> is coming to Portland, > Oregon! Join us October 5-9.* > *Register now to take advantage of the Early Bird discount > <https://www.eventbrite.com/e/puppetconf-2015-october-5-9-tickets-13115894995?discount=EarlyBird> > * > *—**save $249!* > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to puppet-users+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/puppet-users/CAMJiBK7OQyU77x_hugf6B%2BghkA5_YXQGZs8s3%2BUqK3DVsbPCHA%40mail.gmail.com > <https://groups.google.com/d/msgid/puppet-users/CAMJiBK7OQyU77x_hugf6B%2BghkA5_YXQGZs8s3%2BUqK3DVsbPCHA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > Josh -- Josh Cooper Developer, Puppet Labs *PuppetConf 2015 <http://2015.puppetconf.com/> is coming to Portland, Oregon! Join us October 5-9.* *Register now to take advantage of the Final Countdown discount <https://www.eventbrite.com/e/puppetconf-2015-october-5-9-register-now-its-the-final-countdown-tickets-13115894995?discount=FinalCountdown> * *—**save $149!* -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/CA%2Bu97un7P0nbmqmRcwMWFUtf84Ec5KVvxuXQCL0yQGqEBnPyvQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
