Currently, `Proxmox.window.Edit` initializes `extraRequestParams` to an object that, if not overwritten, is shared between all instances of subclasses. This bears the danger of modifying the shared object in a subclass instead of overwriting it, which affects all edit windows of the current session and can cause hard-to-catch UI bugs [1]
- Patch 1/3 fixes such an UI bug. - Patch 2/3 (optional) fixes other occurrences of the pattern from 1/3, which are not buggy at the moment, but may become in the future. - Patch 3/3 (optional) changes `Proxmox.window.Edit` to make this class of bugs less likely in the future. Changes from v1: - Patch 1/3: avoid unnecessary quotes - Patch 2/3 + 3/3 are new [1] https://lists.proxmox.com/pipermail/pve-devel/2024-March/062179.html manager: Friedrich Weber (2): ui: pool members: avoid setting request parameter for all edit windows ui: pool members: avoid sharing object for extra request parameters www/manager6/grid/PoolMembers.js | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) widget-toolkit: Friedrich Weber (1): window: edit: avoid shared object for extra request params src/window/Edit.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) Summary over all repositories: 2 files changed, 10 insertions(+), 0 deletions(-) -- Generated by git-murpp 0.5.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel