memtest86+ ships a config-snippet for grub configuration, and is thus
present on installations using grub (although currently not functional
when secure-boot is enabled).

adding an equivalent entry for memtest86+ on systemd-booted systems
seems like an improvment and a step to having similar functionality in
our different boot-loader setups.

Tested by installing proxmox-kernel-helper with this patch and running
proxmox-boot-tool reinit, followed by rebooting into memtest86+ on a
systemd-booted system.

Suggested-by: Daniel Herzig <[email protected]>
Signed-off-by: Stoiko Ivanov <[email protected]>
---
not 100% sure if it's worth adding, but both Daniel and I thought this might
exist and I remember missing it once on a host of mine

 src/bin/proxmox-boot-tool | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool
index 95d699d..b785c7d 100755
--- a/src/bin/proxmox-boot-tool
+++ b/src/bin/proxmox-boot-tool
@@ -196,6 +196,17 @@ init_bootloader() {
                        echo "timeout 3" > "$esp_mp/$PMX_LOADER_CONF.tmp"
                        echo "default proxmox-*" >> 
"$esp_mp/$PMX_LOADER_CONF.tmp"
                        mv "$esp_mp/$PMX_LOADER_CONF.tmp" 
"$esp_mp/$PMX_LOADER_CONF"
+                       memtest=memtest86+x64.efi
+                       memtest_conf="$esp_mp/loader/entries/$memtest.conf"
+                       if [ -f "/boot/$memtest" ]; then
+                               echo "Adding $memtest .."
+                               cp "/boot/$memtest" "$esp_mp/EFI/"
+                               cat > "$memtest_conf.tmp" <<- EOF
+                                       title Memory test ($memtest)
+                                       efi   /EFI/$memtest
+                               EOF
+                               mv "$memtest_conf.tmp" "$memtest_conf"
+                       fi
                fi
        else
                echo "Installing grub i386-pc target.."
-- 
2.47.3




Reply via email to