[EMAIL PROTECTED] wrote on Wed, 14 Mar 2007 17:23 -0500:
> > [EMAIL PROTECTED] wrote on Wed, 14 Mar 2007 16:11 -0500:
> >> Let me know how these changes look, and if someone gets a chance to
> >> look at performance differences, that would be great.
> >
> > Sounds good from the description. I'll take a look at the encoding
> @@ -642,10 +642,11 @@ struct PVFS_servreq_readdir
> PVFS_ds_position token; /* dir offset */
> uint32_t dirent_count; /* desired # of entries */
> };
> -endecode_fields_4_struct(
> +endecode_fields_5_struct(
> PVFS_servreq_readdir,
> PVFS_handle, handle,
> PVFS_fs_id, fs_id,
> + skip4,,
> PVFS_ds_position, token,
> uint32_t, dirent_count)
Each one of these structs must be fully padded in case something
comes after it. Instead of adding another pad after dirent_count to
do this, you could nestle fs_id + dirent_count together, before or
after the 64-bit token. Actually maybe that's not true. Nothing
will come after this. But you can get rid of the pad by rearranging
a bit.
Otherwise looks great. I skipped big sectionss of whitespace only
changes. And you probably don't want the nightly-tests.cfg to go
in.
-- Pete
_______________________________________________
Pvfs2-developers mailing list
Pvfs2-developers@beowulf-underground.org
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
