On 07/21/2015 09:32 AM, Becky Ligon wrote:
Rob:
We will take a look and update subversion as necessary.
Here's a new version of the patch. Found two more spots that were
failing when they shouldn't.
==rob
Becky
On Tue, Jul 21, 2015 at 9:50 AM, Rob Latham <r...@mcs.anl.gov
<mailto:r...@mcs.anl.gov>> wrote:
Picky compilers now tread "set but not used" as a warning, and
Werror causes some of the bdb feature checks to fail improperly.
I think I still have commit privileges but I don't think it's
appropriate for me to just jam these into the tree.
==rob
--
Rob Latham
Mathematics and Computer Science Division
Argonne National Lab, IL USA
_______________________________________________
Pvfs2-developers mailing list
Pvfs2-developers@beowulf-underground.org
<mailto:Pvfs2-developers@beowulf-underground.org>
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
--
Rob Latham
Mathematics and Computer Science Division
Argonne National Lab, IL USA
>From 6fa92456b72b0095ed403c42d774afcdd07697f7 Mon Sep 17 00:00:00 2001
From: Rob Latham <r...@mcs.anl.gov>
Date: Mon, 20 Jul 2015 16:45:43 -0500
Subject: [PATCH] Strict compiler flags fail tests that should pass
Werror will carp about "set but not used" variables in several places.
these changes finally get pvfs building error-free on my laptop
---
maint/config/bdb.m4 | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/maint/config/bdb.m4 b/maint/config/bdb.m4
index e022bd09..241b079c 100644
--- a/maint/config/bdb.m4
+++ b/maint/config/bdb.m4
@@ -163,7 +163,7 @@ AC_DEFUN([AX_BERKELEY_DB],
return;
}
], [
- DB *db;
+ DB *db=db;
db->set_errcall(db, error_callback_fn);
], AC_MSG_RESULT(yes)
@@ -188,7 +188,7 @@ AC_DEFUN([AX_BERKELEY_DB],
return;
}
], [
- DB *db;
+ DB *db=db;
db->set_errcall(db, error_callback_fn);
], AC_MSG_RESULT(no),
@@ -215,6 +215,7 @@ AC_DEFUN([AX_BERKELEY_DB],
u_int32_t flags = 0;
ret = db->stat(db, &dummy, malloc, flags);
+ ret++;
], AC_MSG_RESULT(yes)
AC_DEFINE(HAVE_UNKNOWN_PARAMETER_TO_DB_STAT, 1,
Define if DB stat function takes malloc function ptr)
@@ -235,6 +236,7 @@ AC_DEFUN([AX_BERKELEY_DB],
u_int32_t flags = 0;
ret = db->stat(db, txnid, NULL, flags);
+ ret++;
], AC_MSG_RESULT(yes)
AC_DEFINE(HAVE_TXNID_PARAMETER_TO_DB_STAT, 1,
Define if DB stat function takes txnid parameter)
@@ -259,6 +261,7 @@ AC_DEFUN([AX_BERKELEY_DB],
int mode = 0;
ret = db->open(db, txnid, file, database, type, flags, mode);
+ ret++;
], AC_MSG_RESULT(yes)
AC_DEFINE(HAVE_TXNID_PARAMETER_TO_DB_OPEN, 1,
Define if DB open function takes a txnid parameter),
@@ -295,6 +298,7 @@ AC_DEFUN([AX_BERKELEY_DB],
int pagesize;
ret = db->get_pagesize(db, &pagesize);
+ ret++;
], AC_MSG_RESULT(yes)
AC_DEFINE(HAVE_DB_GET_PAGESIZE, 1, [Define if DB has get_pagesize function]),
AC_MSG_RESULT(no))
--
1.9.1
_______________________________________________
Pvfs2-developers mailing list
Pvfs2-developers@beowulf-underground.org
http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
