Using a property has my preference, as it makes the whole api consistent. Setting a position as a tuple is quite common. I would make the original set_position private (so rename to _set_position) and then let set_position raise a deprecation warning and call it. We can then remove it a few releases later.
Rob Op woensdag 28 oktober 2015 18:36:49 UTC+1 schreef Leif Theden: > > I'm worried that lack of a position setter will break code that relies on > it. I've got two ideas on how to handle it: > > 1. Leave it as is > 2. Use the following: > > https://gist.github.com/bitcraft/cbb6dba134fcd6edd96c > > I've test the above on 2.7 and 3.4 and it worked fine. > > > On Wednesday, October 28, 2015 at 11:20:15 AM UTC-5, Benjamin Moran wrote: > >> Thanks for the feedback. >> >> I left the set_position method there because it's not possible to pass >> more than one value for a @position.setter. If added, it will require x,y >> to be passed as a tuple. That's OK, but set_position has to stay for now >> anyway so it doesn't break any code. >> >> -Ben >> >> -- You received this message because you are subscribed to the Google Groups "pyglet-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/pyglet-users. For more options, visit https://groups.google.com/d/optout.
