Looking forward to removing legacy code from pyglet! I did this little exercise in the past...took just a couple hours to get it right. Make sure that you get the docstrings right so it doesn't affect the auto-generated documentation. I would offer my code as a PR, but I dropped 2.x support.
On Monday, October 26, 2015 at 7:09:01 AM UTC-5, Benjamin Moran wrote: > > Great! I'll send a pull request your way sometime soon. > > -Ben > > > On Monday, October 26, 2015 at 9:06:06 PM UTC+9, Rob wrote: >> >> I am definitely in favor of that. I also use @property and such in the >> refactoring. >> >> Rob >> >> Op maandag 26 oktober 2015 13:04:46 UTC+1 schreef Benjamin Moran: >>> >>> Thanks for the reply, Rob. With that in mind, I wouldn't mind cleaning >>> up and modernizing some of the existing modules a bit. I've got my eye on >>> the sprite module for a start. I'm thinking it would be a lot more readable >>> if @property and @<x>.setter decorators were used instead of the current >>> property declarations. If I were to go through and make those changes, >>> would that be something you would consider pulling into master? >>> >>> -Ben >>> >>> >>> >>> >>> On Monday, October 26, 2015 at 8:42:14 PM UTC+9, Rob wrote: >>>> >>>> I agree. I currently only test 2.7 and 3.4. I guess that 2.6 and 3.2 >>>> are already old enough to not consider for pyglet anymore. 3.3 is also >>>> questionable. >>>> >>>> Rob >>>> >>>> Op woensdag 21 oktober 2015 20:27:26 UTC+2 schreef Leif Theden: >>>>> >>>>> I think that 2.7 is fine. The legacy code in pyglet (>2.6) likely >>>>> exists because it was written a long time ago, and not likely because it >>>>> written to be compatible with old python. Python 2.6 is nearly 8 years >>>>> old >>>>> now and isn't required except on odd linux (redhat, etc). >>>>> >>>>> I've considered exactly what you are proposing, using SDL2 for input, >>>>> but I think that you will have a lot more work to do. AFAIK, you will >>>>> need >>>>> to use all of SDL2 (windowing, events, etc). Pyglet interfaces at the OS >>>>> level (with ctypes), so you *may* have to re-implement more than just the >>>>> joystick API. Something to think about anyway. >>>>> >>>>> On Tuesday, October 6, 2015 at 9:36:26 AM UTC-5, Benjamin Moran wrote: >>>>> >>>>>> Hi guys, >>>>>> >>>>>> New user of pyglet, and potential contributor. I'm not sure if the >>>>>> core developers visit this forum, but I thought it was a good place to >>>>>> start. >>>>>> Basically, I want to implement support for SDL2 GameController_API >>>>>> style controller mapping, and wanted to knowthe minimum Python version I >>>>>> should target. Python 3 is a given, but is 2.7 old enough on the 2.x >>>>>> branch? Does pyglet still officially support older than that? >>>>>> >>>>>> In case anyone is not familar with the SDL2 Game Controller API, it's >>>>>> basically a way to have game controllers "just work" on >>>>>> Linux/Max/Windows. >>>>>> It presents an internal layout that mimics the ubiqitous Xbox360 layout. >>>>>> There is also an internal database of dozens of popular controllers that >>>>>> just work out of the box. For controllers that are not recognised yet, >>>>>> there is the ability to load mappings from a file >>>>>> (SDL_GameControllerAddMappingsFromFile), or automatically from an >>>>>> environmental value (SDL_GAMECONTROLLERCONFIG), as is the case when >>>>>> you launch a game under Steam. >>>>>> SDL Wiki page: http://wiki.libsdl.org/CategoryGameController >>>>>> GameController mapping database: >>>>>> https://github.com/gabomdq/SDL_GameControllerDB >>>>>> >>>>>> This would be built on top of the existing pyglet joystick API, in >>>>>> much the same way as SDL2 does it. >>>>>> >>>>>> Any feedback would be appreciated. >>>>>> >>>>>> -Ben >>>>>> >>>>>> >>>>>> -- You received this message because you are subscribed to the Google Groups "pyglet-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/pyglet-users. For more options, visit https://groups.google.com/d/optout.
