Daniel, I'm not very fluent in Mercurial either, so I tend to let PyCharm handle most of the branch management. There are a few different types of branches possible in Mercurial, but I believe pyglet/bitbucket is using "named branches". I could be wrong on this though.
It's generally a good idea to make a new branch for every pull request you want to do. Your current pull request is from your default branch. The problem is that if you make any more commits to your "default" branch now, it will also show up on your existing pull request. The general overview would be to: 1. Make a new branch (new_sprite_method, or something like that). 2. Make your modifications and commit it to your pyglet fork. 3. Make a new pull request from that branch. On Saturday, April 2, 2016 at 1:07:10 AM UTC+9, Daniel Gillet wrote: > > Hello, > > I'll make a pull request. But I'm not too familiar with Mercurial (I'm > more familiar with git). I already forked pyglet repo a while ago, and I > already made one commit there and sent a pull request ( > https://bitbucket.org/pyglet/pyglet/pull-requests/22/fix-memory-leak-in-issue-66/diff > ). > > My problem now is that I'm not sure what is the best way to go. In git, I > would create a new branch from master. I know I could go a commit back with > `hg update hash_previous_commit`. But then should I just make my changes > and commit them there ? Should I create a *named branch* ? > > Also I noticed my repo is a couple of commits behind pyglet repo. I did a > pull, but now I'm afraid to merge on top of my initial commit. I'm a bit > lost. :) > > A bit of guidance would be much appreciated. Also on which branch should I > make my pull request ? > > Otherwise another solution would be to clone again my repo somewhere else. > > Daniel. > -- You received this message because you are subscribed to the Google Groups "pyglet-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to pyglet-users+unsubscr...@googlegroups.com. To post to this group, send email to pyglet-users@googlegroups.com. Visit this group at https://groups.google.com/group/pyglet-users. For more options, visit https://groups.google.com/d/optout.
